[Feature-8245][Alert] Add Alert Plugin Telegram by pinkhello · Pull Request #8246 · apache/dolphinscheduler

pinkhello · 2022-01-28T13:08:41Z

Purpose of the pull request

This pull request add alert telegram plugin

Brief change log

Add dolphinscheduler-alert-telegram to root pom.xml
Add dolphinscheduler-alert-telegram to dolphinscheduler-alert/dolphinscheduler-alert-plugins/pom.xml
Add dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-telegram folder
Modify dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-slack/.../SlackAlertChannelFactory.java
Modify dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-slack/.../SlackParamsConstants.java
Modify dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-slack/.../SlackSender.java
Modify dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-slack/.../SlackSenderTest.java

Verify this pull request

Added dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-telegram/.../TelegramAlertChannelFactoryTest.java and dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-telegram/.../TelegramSenderTest.java to verify the change.

close #8245

zhongjiajie · 2022-01-29T03:49:08Z

@pinkhello I approve and run CI. but please solved the conflict.

zhongjiajie · 2022-01-29T03:49:33Z

@pinkhello I approve and run CI. but please solved the conflict.

zhongjiajie · 2022-01-29T03:50:05Z

Seem you missing the ASF license header

ERROR the following files don't have a valid license header: 
679
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-telegram/README.MD
680
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-telegram/src/main/java/org/apache/dolphinscheduler/plugin/alert/telegram/TelegramAlertChannel.java
681
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-telegram/src/main/java/org/apache/dolphinscheduler/plugin/alert/telegram/TelegramAlertChannelFactory.java
682
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-telegram/src/main/java/org/apache/dolphinscheduler/plugin/alert/telegram/TelegramAlertConstants.java
683
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-telegram/src/main/java/org/apache/dolphinscheduler/plugin/alert/telegram/TelegramParamsConstants.java
684
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-telegram/src/main/java/org/apache/dolphinscheduler/plugin/alert/telegram/TelegramSender.java

…ugin

pinkhello · 2022-01-29T04:08:51Z

@pinkhello I approve and run CI. but please solved the conflict.

@zhongjiajie
OK , DONE

pinkhello · 2022-01-29T04:14:47Z

Seem you missing the ASF license header

ERROR the following files don't have a valid license header: 
679
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-telegram/README.MD
680
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-telegram/src/main/java/org/apache/dolphinscheduler/plugin/alert/telegram/TelegramAlertChannel.java
681
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-telegram/src/main/java/org/apache/dolphinscheduler/plugin/alert/telegram/TelegramAlertChannelFactory.java
682
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-telegram/src/main/java/org/apache/dolphinscheduler/plugin/alert/telegram/TelegramAlertConstants.java
683
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-telegram/src/main/java/org/apache/dolphinscheduler/plugin/alert/telegram/TelegramParamsConstants.java
684
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-telegram/src/main/java/org/apache/dolphinscheduler/plugin/alert/telegram/TelegramSender.java

done

pinkhello · 2022-01-29T04:20:59Z

@pinkhello I approve and run CI. but please solved the conflict.

@zhongjiajie resolved

zhongjiajie · 2022-01-29T07:07:27Z

Just approve to run the CI right now

pinkhello · 2022-01-29T08:07:25Z

Just approve to run the CI right now

done

codecov-commenter · 2022-01-29T08:25:49Z

Codecov Report

Merging #8246 (ecc21d1) into dev (c160bfb) will increase coverage by 0.15%.
The diff coverage is 69.56%.

@@             Coverage Diff              @@
##                dev    #8246      +/-   ##
============================================
+ Coverage     45.16%   45.32%   +0.15%     
- Complexity     3983     3999      +16     
============================================
  Files           678      683       +5     
  Lines         26343    26502     +159     
  Branches       2836     2845       +9     
============================================
+ Hits          11899    12013     +114     
- Misses        13321    13362      +41     
- Partials       1123     1127       +4

Impacted Files	Coverage Δ
...duler/plugin/alert/slack/SlackParamsConstants.java	`33.33% <ø> (ø)`
.../plugin/alert/telegram/TelegramAlertConstants.java	`0.00% <0.00%> (ø)`
...plugin/alert/telegram/TelegramParamsConstants.java	`0.00% <0.00%> (ø)`
...er/plugin/alert/telegram/TelegramAlertChannel.java	`16.66% <16.66%> (ø)`
...cheduler/plugin/alert/telegram/TelegramSender.java	`54.54% <54.54%> (ø)`
...r/plugin/alert/slack/SlackAlertChannelFactory.java	`100.00% <100.00%> (ø)`
...lphinscheduler/plugin/alert/slack/SlackSender.java	`25.00% <100.00%> (ø)`
...in/alert/telegram/TelegramAlertChannelFactory.java	`100.00% <100.00%> (ø)`
...org/apache/dolphinscheduler/remote/utils/Host.java	`37.77% <0.00%> (-2.23%)`	⬇️
...inscheduler/common/task/sqoop/SqoopParameters.java	`74.00% <0.00%> (-2.00%)`	⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c160bfb...ecc21d1. Read the comment docs.

yimaixinchen

errorCode might be standard.can replace error_code for errorCode

sonarqubecloud · 2022-01-31T01:40:42Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
1 Security Hotspot
1 Code Smell

70.7% Coverage
4.2% Duplication

pinkhello · 2022-01-31T15:16:15Z

PasswordParam class check error！

pinkhello · 2022-02-04T09:55:11Z

errorCode might be standard.can replace error_code for errorCode
done! Sonar check error cause by PasswordParam

caishunfeng

LGTM

zhongjiajie

LGTM

zhongjiajie · 2022-02-07T01:52:25Z

Hi @pinkhello , thanks for your contribution and welcome to join the community 🎉 . If you want to contribute but could not find issues, maybe you could start in #5689 or just search our issue list https://github.com/apache/dolphinscheduler/issues. Looking forward to your next contribution

zhongjiajie · 2022-02-07T02:01:18Z

BTW @pinkhello , we have WeChat groups to discuss dolphinscheduler’s feature and usage, and publish some tasks wanted some time. If you are interested in join WeChat group, please connect my WeChat id zhongjiajie955

pinkhello added 6 commits January 28, 2022 20:40

feat: add alert telegram

c9e082e

feat: test ut

a1828e1

feat: add telegram alert plugin

c552a12

feat: test ut

e6b7102

fix web word

429b96b

feat: add ui

ec48536

pinkhello mentioned this pull request Jan 28, 2022

[Feature-8245][Alert] add telegram alter plugin doc. apache/dolphinscheduler-website#666

Merged

zhongjiajie added enhancement New feature or request first time contributor First-time contributor feature new feature plug-in labels Jan 29, 2022

zhongjiajie assigned pinkhello Jan 29, 2022

zhongjiajie requested review from CalvinKirs and caishunfeng January 29, 2022 03:50

pinkhello added 3 commits January 29, 2022 12:02

ci

3e59115

Merged error

a58b983

merged github.com:apache/dolphinscheduler:webexteams into telegram-pl…

955b814

…ugin

pinkhello closed this Jan 29, 2022

pinkhello reopened this Jan 29, 2022

feat: add ASF License Header

5beddcc

feat: sonar

d461608

yimaixinchen reviewed Jan 29, 2022

View reviewed changes

pinkhello added 5 commits January 30, 2022 10:37

feat: sonar

66ea5bc

feat: error_code

14c0070

feat: add password validate

8ed9b28

feat: fix error_code

01b87ad

feat: test

ecc21d1

caishunfeng approved these changes Feb 7, 2022

View reviewed changes

zhongjiajie approved these changes Feb 7, 2022

View reviewed changes

zhongjiajie merged commit 84b004d into apache:dev Feb 7, 2022

zhongjiajie changed the title ~~[Feature-8245][Alert] Support Alert Telegram Plugin~~ [Feature-8245][Alert] Add Alert Plugin Telegram Feb 7, 2022

Conversation

pinkhello commented Jan 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of the pull request

Brief change log

Verify this pull request

Uh oh!

zhongjiajie commented Jan 29, 2022

Uh oh!

zhongjiajie commented Jan 29, 2022

Uh oh!

zhongjiajie commented Jan 29, 2022

Uh oh!

pinkhello commented Jan 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pinkhello commented Jan 29, 2022

Uh oh!

pinkhello commented Jan 29, 2022

Uh oh!

zhongjiajie commented Jan 29, 2022

Uh oh!

pinkhello commented Jan 29, 2022

Uh oh!

codecov-commenter commented Jan 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

yimaixinchen left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jan 31, 2022

Uh oh!

pinkhello commented Jan 31, 2022

Uh oh!

pinkhello commented Feb 4, 2022

Uh oh!

caishunfeng left a comment

Choose a reason for hiding this comment

Uh oh!

zhongjiajie left a comment

Choose a reason for hiding this comment

Uh oh!

zhongjiajie commented Feb 7, 2022

Uh oh!

zhongjiajie commented Feb 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pinkhello commented Jan 28, 2022 •

edited

Loading

pinkhello commented Jan 29, 2022 •

edited

Loading

codecov-commenter commented Jan 29, 2022 •

edited

Loading