Skip to content

[Feature][UI Next]Fix the routing problem of the user management module#8251

Merged
CalvinKirs merged 1 commit into
apache:devfrom
labbomb:labbomb
Jan 29, 2022
Merged

[Feature][UI Next]Fix the routing problem of the user management module#8251
CalvinKirs merged 1 commit into
apache:devfrom
labbomb:labbomb

Conversation

@labbomb
Copy link
Copy Markdown
Member

@labbomb labbomb commented Jan 29, 2022

Purpose of the pull request

Please refer to the main issue #8070 .

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Copy link
Copy Markdown
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #8251 (fc7e1dd) into dev (7f4d26e) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #8251      +/-   ##
============================================
- Coverage     44.95%   44.94%   -0.01%     
+ Complexity     3951     3950       -1     
============================================
  Files           672      672              
  Lines         26182    26182              
  Branches       2825     2825              
============================================
- Hits          11769    11768       -1     
  Misses        13304    13304              
- Partials       1109     1110       +1     
Impacted Files Coverage Δ
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f4d26e...fc7e1dd. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@CalvinKirs CalvinKirs merged commit c160bfb into apache:dev Jan 29, 2022
@CalvinKirs CalvinKirs added this to the 2.1.0-release milestone Jan 29, 2022
@CalvinKirs CalvinKirs added the UI ui and front end related label Jan 29, 2022
@davidzollo
Copy link
Copy Markdown
Contributor

good job

1 similar comment
@davidzollo
Copy link
Copy Markdown
Contributor

good job

@labbomb labbomb deleted the labbomb branch January 29, 2022 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants