Skip to content

fix jdbc connect parameters can not input '@' and '.' character#8293

Merged
caishunfeng merged 7 commits into
apache:devfrom
zhuxt2015:Bug-8135
Feb 18, 2022
Merged

fix jdbc connect parameters can not input '@' and '.' character#8293
caishunfeng merged 7 commits into
apache:devfrom
zhuxt2015:Bug-8135

Conversation

@zhuxt2015
Copy link
Copy Markdown
Contributor

This closes #8135

Purpose of the pull request

fix jdbc connect parameters can not input '@' and '.' character

Brief change log

Verify this pull request

This pull request is already covered by existing tests, such as (please describe tests).

can input '@' or '.' character in jdbc connect parameters
image

@zhongjiajie zhongjiajie added bug Something isn't working first time contributor First-time contributor plug-in labels Feb 7, 2022
@zhongjiajie
Copy link
Copy Markdown
Member

Could you add some unit test to it? @zhuxt2015

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 7, 2022

Codecov Report

Merging #8293 (780f303) into dev (b75f67a) will increase coverage by 0.03%.
The diff coverage is 32.55%.

❗ Current head 780f303 differs from pull request most recent head 8f42a17. Consider uploading reports for the commit 8f42a17 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #8293      +/-   ##
============================================
+ Coverage     45.30%   45.34%   +0.03%     
- Complexity     3994     4025      +31     
============================================
  Files           680      686       +6     
  Lines         26459    26702     +243     
  Branches       2848     2867      +19     
============================================
+ Hits          11987    12107     +120     
- Misses        13339    13450     +111     
- Partials       1133     1145      +12     
Impacted Files Coverage Δ
...duler/api/controller/TaskDefinitionController.java 3.22% <0.00%> (ø)
...api/service/impl/ProcessDefinitionServiceImpl.java 31.90% <0.00%> (ø)
.../org/apache/dolphinscheduler/common/Constants.java 80.00% <ø> (ø)
...duler/common/task/switchtask/SwitchParameters.java 0.00% <0.00%> (ø)
...va/org/apache/dolphinscheduler/dao/entity/K8s.java 0.00% <0.00%> (ø)
...ache/dolphinscheduler/dao/entity/K8sNamespace.java 0.00% <0.00%> (ø)
...dolphinscheduler/service/k8s/K8sClientService.java 0.00% <0.00%> (ø)
...lphinscheduler/service/process/ProcessService.java 31.96% <0.00%> (ø)
...inscheduler/service/queue/MasterPriorityQueue.java 0.00% <0.00%> (ø)
...r/service/queue/PeerTaskInstancePriorityQueue.java 68.00% <0.00%> (-5.92%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b75f67a...8f42a17. Read the comment docs.

@zhuxt2015
Copy link
Copy Markdown
Contributor Author

Could you add some unit test to it? @zhuxt2015

yes, I'll add a unit test

@zhuxt2015
Copy link
Copy Markdown
Contributor Author

Error: SonarCloud server [https://sonarcloud.io/] can not be reached @zhongjiajie I don't know why appear this error, can you help me resolve

Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me if CI pass, thanks for your contribution

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@zhongjiajie
Copy link
Copy Markdown
Member

I restart the failing CI just now

Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng merged commit 2a14060 into apache:dev Feb 18, 2022
@zhongjiajie
Copy link
Copy Markdown
Member

Thanks @caishunfeng for reviewing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working first time contributor First-time contributor plug-in

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [DataSource] jdbc connect parameters can not input '@'

4 participants