Skip to content

[Feature][UI Next] Add task definition.#8297

Merged
caishunfeng merged 2 commits into
apache:devfrom
songjianet:feat-task-definition
Feb 7, 2022
Merged

[Feature][UI Next] Add task definition.#8297
caishunfeng merged 2 commits into
apache:devfrom
songjianet:feat-task-definition

Conversation

@songjianet
Copy link
Copy Markdown
Member

@songjianet songjianet commented Feb 7, 2022

Purpose of the pull request

#7928
image
image
image
image
image

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

labbomb
labbomb previously approved these changes Feb 7, 2022
Copy link
Copy Markdown
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #8297 (1a3739f) into dev (a680089) will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #8297      +/-   ##
============================================
+ Coverage     45.14%   45.29%   +0.14%     
- Complexity     3981     3997      +16     
============================================
  Files           678      683       +5     
  Lines         26343    26502     +159     
  Branches       2836     2845       +9     
============================================
+ Hits          11893    12003     +110     
- Misses        13329    13370      +41     
- Partials       1121     1129       +8     
Impacted Files Coverage Δ
...cheduler/plugin/alert/telegram/TelegramSender.java 54.54% <0.00%> (ø)
...er/plugin/alert/telegram/TelegramAlertChannel.java 16.66% <0.00%> (ø)
...plugin/alert/telegram/TelegramParamsConstants.java 0.00% <0.00%> (ø)
...in/alert/telegram/TelegramAlertChannelFactory.java 100.00% <0.00%> (ø)
.../plugin/alert/telegram/TelegramAlertConstants.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a680089...1a3739f. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

0.0% 0.0% Coverage
4.6% 4.6% Duplication

@caishunfeng caishunfeng merged commit 1d6c509 into apache:dev Feb 7, 2022
@songjianet songjianet deleted the feat-task-definition branch February 8, 2022 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants