Skip to content

Remove unused class#8299

Merged
ruanwenjun merged 1 commit into
apache:devfrom
ruanwenjun:dev_wenjun_removeUnusedClass
Feb 8, 2022
Merged

Remove unused class#8299
ruanwenjun merged 1 commit into
apache:devfrom
ruanwenjun:dev_wenjun_removeUnusedClass

Conversation

@ruanwenjun
Copy link
Copy Markdown
Member

Purpose of the pull request

Clear some unused class

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #8299 (046e30d) into dev (896dec2) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #8299      +/-   ##
============================================
+ Coverage     45.28%   45.29%   +0.01%     
+ Complexity     4000     3993       -7     
============================================
  Files           683      680       -3     
  Lines         26539    26460      -79     
  Branches       2849     2849              
============================================
- Hits          12018    11985      -33     
+ Misses        13390    13341      -49     
- Partials       1131     1134       +3     
Impacted Files Coverage Δ
...e/dolphinscheduler/remote/NettyRemotingClient.java 50.70% <0.00%> (-2.82%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 896dec2...046e30d. Read the comment docs.

Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ruanwenjun ruanwenjun merged commit 0938157 into apache:dev Feb 8, 2022
@ruanwenjun ruanwenjun deleted the dev_wenjun_removeUnusedClass branch March 16, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants