[Fix-8367][Master] execute COMPLEMENT_DATA command always missing some ack event#8407
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.0.4-prepare #8407 +/- ##
================================================
Coverage ? 21.01%
Complexity ? 1577
================================================
Files ? 536
Lines ? 22439
Branches ? 2643
================================================
Hits ? 4716
Misses ? 17248
Partials ? 475 Continue to review full report at Codecov.
|
caishunfeng
reviewed
Feb 17, 2022
| //the next process complement | ||
| int create = this.createComplementDataCommand(scheduleDate); | ||
| if (create > 0) { | ||
| logger.info("create complement data command successfully."); |
Contributor
There was a problem hiding this comment.
It's better to add some identify flag in log, such as id or code.
Contributor
|
relative pr in dev: #7976 |
|
SonarCloud Quality Gate failed.
|
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
This pr will close #8367