Skip to content

[Fix-7892][api] Fixed when a non-admin user creates a udf function, resources other than .jar will be displayed in the UDF resource#8458

Merged
caishunfeng merged 1 commit into
apache:devfrom
Lucaszlei:Fix-7892
Feb 24, 2022
Merged

[Fix-7892][api] Fixed when a non-admin user creates a udf function, resources other than .jar will be displayed in the UDF resource#8458
caishunfeng merged 1 commit into
apache:devfrom
Lucaszlei:Fix-7892

Conversation

@Lucaszlei
Copy link
Copy Markdown
Contributor

Fixed when a non-admin user creates a udf function, resources other than .jar will be displayed in the UDF resource

This closes #7892

Verify this pull request

This pull request is already covered by existing tests, such as (please describe tests).
org.apache.dolphinscheduler.api.service.ResourcesServiceTest#testQueryResourceList

…sources other than .jar will be displayed in the UDF resource

This closes apache#7892
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 20, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.35%. Comparing base (df6eef8) to head (5a8c9e4).
⚠️ Report is 2959 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8458      +/-   ##
============================================
- Coverage     45.35%   45.35%   -0.01%     
- Complexity     4028     4029       +1     
============================================
  Files           686      686              
  Lines         26702    26704       +2     
  Branches       2867     2867              
============================================
  Hits          12112    12112              
- Misses        13448    13449       +1     
- Partials       1142     1143       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@yimaixinchen yimaixinchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGtm

Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng added this to the 2.1.0-release milestone Feb 24, 2022
@caishunfeng caishunfeng merged commit 1ffb5d6 into apache:dev Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [api] When a non-admin user creates a udf function, resources other than .jar will be displayed in the UDF resource

4 participants