Skip to content

[Feature][Server] Custom timezone - Add timezone handler unified#8477

Merged
caishunfeng merged 5 commits into
apache:devfrom
caishunfeng:timezone
Feb 24, 2022
Merged

[Feature][Server] Custom timezone - Add timezone handler unified#8477
caishunfeng merged 5 commits into
apache:devfrom
caishunfeng:timezone

Conversation

@caishunfeng
Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng commented Feb 22, 2022

Purpose of the pull request

this pr close #8479
for handle timezone unified

Brief change log

  • date convert of timezone, use the user timezone first, server timezone as default.
  • remove annotation @jsonformat, add spring jaskson config.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 22, 2022

Codecov Report

Merging #8477 (341c598) into dev (95c1192) will decrease coverage by 0.05%.
The diff coverage is 66.07%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #8477      +/-   ##
============================================
- Coverage     45.42%   45.37%   -0.06%     
- Complexity     4034     4037       +3     
============================================
  Files           686      688       +2     
  Lines         26725    26770      +45     
  Branches       2870     2873       +3     
============================================
+ Hits          12139    12146       +7     
- Misses        13440    13476      +36     
- Partials       1146     1148       +2     
Impacted Files Coverage Δ
...org/apache/dolphinscheduler/alert/AlertServer.java 56.41% <0.00%> (-3.05%) ⬇️
.../org/apache/dolphinscheduler/api/dto/AuditDto.java 68.75% <ø> (ø)
...apache/dolphinscheduler/api/dto/ScheduleParam.java 0.00% <ø> (ø)
...rg/apache/dolphinscheduler/api/dto/gantt/Task.java 0.00% <ø> (ø)
...he/dolphinscheduler/api/dto/treeview/Instance.java 0.00% <ø> (ø)
...heduler/api/service/impl/SchedulerServiceImpl.java 8.62% <0.00%> (-0.07%) ⬇️
...he/dolphinscheduler/common/model/DateInterval.java 38.88% <ø> (ø)
...g/apache/dolphinscheduler/common/model/Server.java 0.00% <ø> (ø)
...lphinscheduler/common/model/WorkerServerModel.java 0.00% <ø> (ø)
...che/dolphinscheduler/common/utils/LoggerUtils.java 0.00% <0.00%> (ø)
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95c1192...341c598. Read the comment docs.

@caishunfeng caishunfeng marked this pull request as ready for review February 22, 2022 13:10
@caishunfeng
Copy link
Copy Markdown
Contributor Author

PTAL @tangchunbo

@jim-parsons
Copy link
Copy Markdown
Contributor

jim-parsons commented Feb 23, 2022

PTAL

LGTM
big old newbee~

i had a yamlPropertySourceLoad to init the timeZone, but i think this solution is more convenient~

@caishunfeng caishunfeng added the miss:docs missing documents in PR label Feb 23, 2022
kezhenxu94
kezhenxu94 previously approved these changes Feb 23, 2022
Copy link
Copy Markdown
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little need to change.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 43 Code Smells

61.2% 61.2% Coverage
1.4% 1.4% Duplication

@caishunfeng caishunfeng merged commit 84f2cfe into apache:dev Feb 24, 2022
@caishunfeng
Copy link
Copy Markdown
Contributor Author

Thanks for your review.

@caishunfeng
Copy link
Copy Markdown
Contributor Author

relative issue: #8385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

miss:docs missing documents in PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][Server] Custom timezone - Add timezone handler unified

5 participants