Skip to content

Add a property to enable/disable metrics module#8484

Merged
caishunfeng merged 1 commit into
devfrom
switch/metrics
Feb 24, 2022
Merged

Add a property to enable/disable metrics module#8484
caishunfeng merged 1 commit into
devfrom
switch/metrics

Conversation

@kezhenxu94
Copy link
Copy Markdown
Member

This patch add a property to enable/disable the metrics module, allowing users who don't need metrics to disable the configuration without effecting the performance.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 22, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.36%. Comparing base (843ab3f) to head (f922823).
⚠️ Report is 2929 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8484      +/-   ##
============================================
- Coverage     45.38%   45.36%   -0.02%     
+ Complexity     4031     4028       -3     
============================================
  Files           686      686              
  Lines         26725    26725              
  Branches       2870     2870              
============================================
- Hits          12130    12125       -5     
- Misses        13451    13453       +2     
- Partials       1144     1147       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng merged commit fa19006 into dev Feb 24, 2022
@zhongjiajie zhongjiajie deleted the switch/metrics branch February 24, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants