[Feature-#8373][MasterServer] Dependent tasks can re-run automatically in the case of complement#8496
Merged
caishunfeng merged 7 commits intoapache:devfrom Feb 25, 2022
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #8496 +/- ##
============================================
- Coverage 45.38% 45.22% -0.16%
+ Complexity 4031 4030 -1
============================================
Files 686 688 +2
Lines 26725 26826 +101
Branches 2870 2882 +12
============================================
+ Hits 12130 12133 +3
- Misses 13451 13544 +93
- Partials 1144 1149 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
caishunfeng
reviewed
Feb 23, 2022
Contributor
caishunfeng
left a comment
caishunfeng
left a comment
There was a problem hiding this comment.
Hi @SbloodyS It is better to show the brief change log of this pr, which can let others understand the content of pr more quickly.
...uler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java
Outdated
Show resolved
Hide resolved
...uler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java
Show resolved
Hide resolved
...uler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/WorkFlowLineageMapper.xml
Show resolved
Hide resolved
| processService.queryDependentProcessDefinitionByProcessDefinitionCode(processDefinitionCode); | ||
|
|
||
| for (DependentProcessDefinition dependentProcessDefinition : dependentProcessDefinitionList) { | ||
| if (dependentProcessDefinition.getDependentCycle() == processDefinitionCycle) { |
Contributor
There was a problem hiding this comment.
Please add some notes here.
...uler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/WorkFlowLineageMapper.xml
Outdated
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed. |
wangxj3
changed the title
Contributor
|
@SbloodyS Well done, thanks for your contribution. |
SbloodyS
added
improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
This pr will close #8373
Brief change log
queryDependentProcessDefinitionByProcessDefinitionCodeindolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/WorkFlowLineageMapper.xmland DependentProcessDefinition entity and query functionqueryDependentProcessDefinitionByProcessDefinitionCodeindolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.javaquerySchedulesByProcessDefinitionCodesindolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ScheduleMapper.xmland query functionqueryWorkerGroupByProcessDefinitionCodesindolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.javacreateComplementDependentCommandindolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.javaand its related to unit test and its controller.Execution process: