[Feature-8485][task-plugin] add EMR task plugin to support submit task to AWS EMR#8503
Conversation
|
@ronyang1985 It seems we are without UI part, is there any plan to add UI part |
|
I restart the failing test. |
@zhongjiajie I am not very good at front-end development, the ui part may be added after ui-next is completed by other contributors? |
…per to match AWS api definition
I got it, cc: @songjianet . I also add the label |
|
FYI, UT do not pass |
Codecov Report
@@ Coverage Diff @@
## dev #8503 +/- ##
============================================
- Coverage 45.38% 45.32% -0.07%
- Complexity 4031 4060 +29
============================================
Files 686 696 +10
Lines 26725 26978 +253
Branches 2870 2889 +19
============================================
+ Hits 12130 12227 +97
- Misses 13451 13600 +149
- Partials 1144 1151 +7
Continue to review full report at Codecov.
|
@zhongjiajie hi, about the document, i submit a pr ,apache/dolphinscheduler-website#702 |
…ler/common/enums/TaskType.java learned it, thx Co-authored-by: Wenjun Ruan <wenjun@apache.org>
…n/java/org/apache/dolphinscheduler/plugin/task/emr/EmrTask.java Co-authored-by: caishunfeng <caishunfeng2021@gmail.com>
…shade-plugin to solve dependency conflict
There was a problem hiding this comment.
When worker submit an EMR task, it will query the task status from remote server and wait the task success.
Can the task get status by callback function? I am not familiar with AWS EMR.
It seems in the current implementation will have issue when do task failover, since the master cannot get EMR appId(like spark applicaId), the id will only send to master after the task finished.
If I miss anything please let me know.
|
Yes, we have some problems in different tasks failover. Now, we get yarn ids from task log, and kill yarn id in task failover. But it cannot support custom unknown tasks, such as k8s and EMR tasks. So we should consider reconstructing the process of task failover. |
|
Clicked the close button by mistake, this PR is ok for me. According to @lenboo said, we can reconstruct the process of task failover in the future. Currently, we can just add |
hi, 'TODO' comment was added |
|
SonarCloud Quality Gate failed. |








Purpose of the pull request
close #8485
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows: