upgrade mybatis-plus to 3.4.3#8515
Merged
Merged
Conversation
lenboo
changed the title
zhongjiajie
previously approved these changes
Feb 24, 2022
Member
zhongjiajie
left a comment
zhongjiajie
left a comment
There was a problem hiding this comment.
License LGTM, do you have time to make a double-check? @CalvinKirs
zhongjiajie
added
dependencies
CalvinKirs
previously approved these changes
Feb 24, 2022
Member
CalvinKirs
left a comment
CalvinKirs
left a comment
There was a problem hiding this comment.
I have confirmed, No license changes.
caishunfeng
reviewed
Feb 24, 2022
|
|
||
| MybatisPlusInterceptor mybatisPlusInterceptor = new MybatisPlusInterceptor(); | ||
| mybatisPlusInterceptor.addInnerInterceptor(new PaginationInnerInterceptor()); | ||
| mybatisPlusInterceptor.addInnerInterceptor(new OptimisticLockerInnerInterceptor()); |
Contributor
There was a problem hiding this comment.
Does it need to add this optimistic lock plugin? This plugin requires the object to have a @Version field to take effect.
Contributor
Author
There was a problem hiding this comment.
You are right, i will remove this.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #8515 +/- ##
============================================
- Coverage 45.37% 45.35% -0.02%
+ Complexity 4029 4027 -2
============================================
Files 686 686
Lines 26725 26736 +11
Branches 2870 2870
============================================
Hits 12126 12126
- Misses 13453 13464 +11
Partials 1146 1146 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Kudos, SonarCloud Quality Gate passed! |
This was referenced Feb 25, 2022
kezhenxu94
pushed a commit
that referenced
this pull request
Mar 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
fix #8513 upgrade mybatis-plus from 3.2.0 to 3.4.3
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows: