[Feature-#8318] [master-server] Sub process transfer parameters to father process#8522
Merged
Conversation
added 2 commits
February 24, 2022 16:06
Contributor
|
Hi @wangxj3 please resolve the conflicts. |
…to subProcessParam # Conflicts: # dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #8522 +/- ##
============================================
+ Coverage 40.09% 40.17% +0.07%
- Complexity 4374 4379 +5
============================================
Files 820 820
Lines 32743 32778 +35
Branches 3640 3648 +8
============================================
+ Hits 13129 13168 +39
+ Misses 18387 18374 -13
- Partials 1227 1236 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
caishunfeng
reviewed
Mar 15, 2022
| List<Property> varPoolProperties = JSONUtils.toList(thisTaskInstanceVarPool, Property.class); | ||
| Map<String, Object> taskParams = JSONUtils.parseObject(taskInstance.getTaskParams(), new TypeReference<Map<String, Object>>() { | ||
| }); | ||
| Object localParams = taskParams.get(LOCAL_PARAMS); |
Contributor
There was a problem hiding this comment.
Should global parameters be handled as well?
Contributor
Author
There was a problem hiding this comment.
the globalParam is a static param for the instance ,so i don't think it's should be handled here.
Contributor
|
Hi @wangxj3 this feature also need to change doc, so I add the |
added 2 commits
March 29, 2022 14:46
…to subProcessParam # Conflicts: # dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java # dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/task/SubTaskProcessor.java # dolphinscheduler-master/src/test/java/org/apache/dolphinscheduler/server/master/SubProcessTaskTest.java # dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
|
Kudos, SonarCloud Quality Gate passed! |
caishunfeng
approved these changes
Mar 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Feature-#8318] [master-server] Sub process transfer parameters to father process
When you use the out param in taskNode of subpeocess, the father processInstance could get the param definde in the subProcess.