Skip to content

[Impreove][Master]remove no meaningful duplicated check code#8552

Merged
caishunfeng merged 1 commit into
apache:devfrom
Yao-MR-zz:dev_refactor
Mar 3, 2022
Merged

[Impreove][Master]remove no meaningful duplicated check code#8552
caishunfeng merged 1 commit into
apache:devfrom
Yao-MR-zz:dev_refactor

Conversation

@Yao-MR-zz
Copy link
Copy Markdown

Purpose of the pull request

remove no meaningful duplicated check code

Brief change log

remove the duplicated check code

Verify this pull request

This pull request is code cleanup without any test coverage.

This change added tests and can be verified as follows:

  • remove the duplicated check code.

@Yao-MR-zz
Copy link
Copy Markdown
Author

just the dulicatede code

image

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #8552 (ad8ab20) into dev (ca6d148) will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #8552      +/-   ##
============================================
- Coverage     45.41%   45.24%   -0.17%     
- Complexity     4039     4040       +1     
============================================
  Files           688      690       +2     
  Lines         26773    26873     +100     
  Branches       2873     2884      +11     
============================================
+ Hits          12158    12160       +2     
- Misses        13466    13564      +98     
  Partials       1149     1149              
Impacted Files Coverage Δ
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 48.21% <0.00%> (-7.15%) ⬇️
...cheduler/api/service/impl/ExecutorServiceImpl.java 41.96% <0.00%> (-5.14%) ⬇️
...inscheduler/api/controller/ExecutorController.java 40.00% <0.00%> (-1.94%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...lphinscheduler/service/process/ProcessService.java 31.88% <0.00%> (-0.08%) ⬇️
...a/org/apache/dolphinscheduler/dao/entity/User.java 74.13% <0.00%> (ø)
.../org/apache/dolphinscheduler/dao/entity/Queue.java 51.61% <0.00%> (ø)
...org/apache/dolphinscheduler/dao/entity/Tenant.java 72.72% <0.00%> (ø)
...rg/apache/dolphinscheduler/api/dto/gantt/Task.java 0.00% <0.00%> (ø)
...rg/apache/dolphinscheduler/dao/entity/Session.java 41.93% <0.00%> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca6d148...ad8ab20. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yimaixinchen
Copy link
Copy Markdown
Contributor

Well I don't think it is duplicate.if it removes, the below codes that the commands.size return NPE .

@Yao-MR-zz
Copy link
Copy Markdown
Author

hi @caishunfeng can you help check this pr ?

@caishunfeng caishunfeng changed the title [Impreove][Core]remove no meaningful duplicated check code [Impreove][Master]remove no meaningful duplicated check code Mar 3, 2022
Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, and I think this is an small change, looking forward to your next more constructive pr.

@caishunfeng caishunfeng merged commit 67a6813 into apache:dev Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants