Skip to content

[DS-7992][feat] Alert module judging strategy#8636

Merged
EricJoy2048 merged 2 commits into
apache:devfrom
qingwli:Feature-7992-2
Mar 14, 2022
Merged

[DS-7992][feat] Alert module judging strategy#8636
EricJoy2048 merged 2 commits into
apache:devfrom
qingwli:Feature-7992-2

Conversation

@qingwli
Copy link
Copy Markdown
Member

@qingwli qingwli commented Mar 1, 2022

Purpose of the pull request

Save the alert strategy when triggered & Change the logic to match the strategy

Brief change log

Please view the design #7992

close #7992

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

48.6% 48.6% Coverage
0.0% 0.0% Duplication

@caishunfeng caishunfeng requested a review from zhuangchong March 2, 2022 04:11
Copy link
Copy Markdown
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@EricJoy2048
Copy link
Copy Markdown
Member

Thank you for your pr @liqingwang , This is a good job.

@qingwli
Copy link
Copy Markdown
Member Author

qingwli commented Mar 14, 2022

I will update the document about the new feature later.

Copy link
Copy Markdown
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@EricJoy2048 EricJoy2048 merged commit 0d8079a into apache:dev Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][Alert] Support PagerDuty Plugin && Alert module judging strategy

3 participants