Skip to content

[Fix][UI Next][V1.0.0-Alpha]Fixed an issue with time picker clearing#8655

Merged
songjianet merged 1 commit into
apache:devfrom
labbomb:labbomb
Mar 2, 2022
Merged

[Fix][UI Next][V1.0.0-Alpha]Fixed an issue with time picker clearing#8655
songjianet merged 1 commit into
apache:devfrom
labbomb:labbomb

Conversation

@labbomb
Copy link
Copy Markdown
Member

@labbomb labbomb commented Mar 2, 2022

Purpose of the pull request

Please refer to the issue #8627.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@songjianet songjianet changed the title [Bug][UI Next][V1.0.0-Alpha]Fixed an issue with time picker clearing [Fix][UI Next][V1.0.0-Alpha]Fixed an issue with time picker clearing Mar 2, 2022
@songjianet songjianet added bug Something isn't working UI ui and front end related labels Mar 2, 2022
Copy link
Copy Markdown
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #8655 (f3c22c4) into dev (7329285) will decrease coverage by 0.01%.
The diff coverage is 9.09%.

❗ Current head f3c22c4 differs from pull request most recent head dd27f26. Consider uploading reports for the commit dd27f26 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #8655      +/-   ##
============================================
- Coverage     45.32%   45.31%   -0.02%     
- Complexity     4071     4073       +2     
============================================
  Files           699      700       +1     
  Lines         27035    27046      +11     
  Branches       2892     2894       +2     
============================================
+ Hits          12254    12256       +2     
- Misses        13628    13638      +10     
+ Partials       1153     1152       -1     
Impacted Files Coverage Δ
...che/dolphinscheduler/api/ApiApplicationServer.java 60.00% <ø> (ø)
...nscheduler/api/configuration/AppConfiguration.java 94.11% <ø> (ø)
...duler/api/interceptor/LoginHandlerInterceptor.java 82.60% <ø> (ø)
...hinscheduler/api/controller/DsErrorController.java 9.09% <9.09%> (ø)
...e/dolphinscheduler/remote/NettyRemotingClient.java 53.52% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7329285...dd27f26. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
44.4% 44.4% Duplication

@songjianet songjianet merged commit 78d7c06 into apache:dev Mar 2, 2022
@labbomb labbomb deleted the labbomb branch March 2, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][UI Next][V1.0.0-Alpha] Click to clear, the time component fails to clear the time interval

3 participants