Skip to content

[python] Increase UT coverage threshold to 0.9#8660

Merged
caishunfeng merged 1 commit into
apache:devfrom
zhongjiajie:py-ut-cover-fail-under-90
Mar 3, 2022
Merged

[python] Increase UT coverage threshold to 0.9#8660
caishunfeng merged 1 commit into
apache:devfrom
zhongjiajie:py-ut-cover-fail-under-90

Conversation

@zhongjiajie
Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie commented Mar 2, 2022

This patch increase Python API unit test coverage
threshold from 85% to 90%. If coverage is under 90%
will fail our the test

@zhongjiajie
[python] Increase UT coverage threshold to 0.9
957918c 
This patch increase Python API unit test coverage
threshold from 85% to 90%. If coverage under 90%
will failed our the test
@zhongjiajie zhongjiajie added enhancement New feature or request Pyscheduler labels Mar 2, 2022
@zhongjiajie zhongjiajie self-assigned this Mar 2, 2022
@zhongjiajie
Copy link
Copy Markdown
Member Author

zhongjiajie commented Mar 2, 2022

PTAL @devosend @jieguangzhou thanks

jieguangzhou
jieguangzhou approved these changes Mar 2, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jieguangzhou jieguangzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongjiajie zhongjiajie requested review from caishunfeng, lenboo and songjianet and removed request for lenboo March 2, 2022 07:50
@zhongjiajie
Copy link
Copy Markdown
Member Author

zhongjiajie commented Mar 2, 2022

Thanks for reviewing @jieguangzhou

@devosend
Copy link
Copy Markdown
Contributor

devosend commented Mar 2, 2022

LGTM

@zhongjiajie
Copy link
Copy Markdown
Member Author

zhongjiajie commented Mar 2, 2022

Restart the failing test

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 2, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 51 Code Smells

6.6% 6.6% Coverage
7.5% 7.5% Duplication

caishunfeng
caishunfeng approved these changes Mar 3, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@caishunfeng caishunfeng merged commit aac960d into apache:dev Mar 3, 2022
@zhongjiajie zhongjiajie deleted the py-ut-cover-fail-under-90 branch March 3, 2022 04:21
@zhongjiajie
Copy link
Copy Markdown
Member Author

zhongjiajie commented Mar 3, 2022

thanks for reviewing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caishunfeng caishunfeng caishunfeng approved these changes

@jieguangzhou jieguangzhou jieguangzhou approved these changes

@songjianet songjianet Awaiting requested review from songjianet

Assignees

@zhongjiajie zhongjiajie

Labels

enhancement New feature or request Pyscheduler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhongjiajie @devosend @caishunfeng @jieguangzhou