Skip to content

[Fix][UI Next][V1.0.0-Alpha] Fixed a problem where safari ICONS are not displayed#8662

Merged
songjianet merged 1 commit into
apache:devfrom
labbomb:labbomb
Mar 2, 2022
Merged

[Fix][UI Next][V1.0.0-Alpha] Fixed a problem where safari ICONS are not displayed#8662
songjianet merged 1 commit into
apache:devfrom
labbomb:labbomb

Conversation

@labbomb
Copy link
Copy Markdown
Member

@labbomb labbomb commented Mar 2, 2022

Purpose of the pull request

Please refer to the main issue #8656.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 2, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.30%. Comparing base (98396d2) to head (ee7c2b2).
⚠️ Report is 2884 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8662      +/-   ##
============================================
- Coverage     45.31%   45.30%   -0.02%     
+ Complexity     4075     4073       -2     
============================================
  Files           700      700              
  Lines         27045    27045              
  Branches       2894     2894              
============================================
- Hits          12256    12252       -4     
- Misses        13637    13639       +2     
- Partials       1152     1154       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@songjianet songjianet added bug Something isn't working UI ui and front end related labels Mar 2, 2022
@songjianet songjianet changed the title [Bug][UI Next][V1.0.0-Alpha]Fixed a problem where safari ICONS are not displayed [Fix][UI Next][V1.0.0-Alpha] Fixed a problem where safari ICONS are not displayed Mar 2, 2022
@songjianet songjianet linked an issue Mar 2, 2022 that may be closed by this pull request
19 tasks
@songjianet
Copy link
Copy Markdown
Member

The operation buttons of other forms can also be viewed.

Copy link
Copy Markdown
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@labbomb
Copy link
Copy Markdown
Member Author

labbomb commented Mar 2, 2022

The operation buttons of other forms can also be viewed.

anything is ok

@songjianet
Copy link
Copy Markdown
Member

The operation buttons of other forms can also be viewed.

anything is ok

Thank you.

@apache apache deleted a comment from labbomb Mar 2, 2022
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 2, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
41.4% 41.4% Duplication

@songjianet songjianet merged commit 2f21c89 into apache:dev Mar 2, 2022
@labbomb labbomb deleted the labbomb branch March 2, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][UI Next][V1.0.0-Alpha] edit and delete button display incorrectly in security/tenant-manage and more

3 participants