Skip to content

[CI][UI Next][V1.0.0-Alpha] Add frontend UI to CI checks and fix the linting problems found#8666

Merged
songjianet merged 1 commit into
devfrom
ui-ci
Mar 2, 2022
Merged

[CI][UI Next][V1.0.0-Alpha] Add frontend UI to CI checks and fix the linting problems found#8666
songjianet merged 1 commit into
devfrom
ui-ci

Conversation

@kezhenxu94
Copy link
Copy Markdown
Member

Remove unused declarations and variables to make CI passed

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #8666 (e94c7d3) into dev (2f21c89) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head e94c7d3 differs from pull request most recent head c2a8d14. Consider uploading reports for the commit c2a8d14 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #8666      +/-   ##
============================================
+ Coverage     45.30%   45.31%   +0.01%     
- Complexity     4073     4075       +2     
============================================
  Files           700      700              
  Lines         27045    27045              
  Branches       2894     2894              
============================================
+ Hits          12252    12256       +4     
+ Misses        13639    13637       -2     
+ Partials       1154     1152       -2     
Impacted Files Coverage Δ
...e/dolphinscheduler/remote/NettyRemotingClient.java 53.52% <0.00%> (+2.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f21c89...c2a8d14. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 2, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

0.0% 0.0% Coverage
20.7% 20.7% Duplication

Copy link
Copy Markdown
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songjianet songjianet changed the title [CI][UI NEXT] Add frontend UI to CI checks and fix the linting problems found [CI][UI Next][V1.0.0-Alpha] Add frontend UI to CI checks and fix the linting problems found Mar 2, 2022
@songjianet songjianet added feature new feature UI ui and front end related labels Mar 2, 2022
@songjianet songjianet merged commit 60a0049 into dev Mar 2, 2022
@kezhenxu94 kezhenxu94 deleted the ui-ci branch March 2, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI&CD feature new feature UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants