Skip to content

[Fix][UI Next][V1.0.0-Alpha] Fix modified the system language, the chart text is not changed to Chinese as expected.#8682

Merged
zhongjiajie merged 1 commit into
apache:devfrom
songjianet:fix-home-page-i18n
Mar 3, 2022
Merged

[Fix][UI Next][V1.0.0-Alpha] Fix modified the system language, the chart text is not changed to Chinese as expected.#8682
zhongjiajie merged 1 commit into
apache:devfrom
songjianet:fix-home-page-i18n

Conversation

@songjianet
Copy link
Copy Markdown
Member

@songjianet songjianet commented Mar 3, 2022

Purpose of the pull request

close #8621

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

…art text is not changed to Chinese as expected.
@songjianet songjianet added bug Something isn't working UI ui and front end related labels Mar 3, 2022
@songjianet songjianet self-assigned this Mar 3, 2022
@songjianet songjianet changed the title [Fix][UI Next][V1.0.0-Alpha] Fix modified the system language, the ch… [Fix][UI Next][V1.0.0-Alpha] Fix modified the system language, the chart text is not changed to Chinese as expected. Mar 3, 2022
Copy link
Copy Markdown
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #8682 (085b2f7) into dev (aac960d) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 085b2f7 differs from pull request most recent head b2c7361. Consider uploading reports for the commit b2c7361 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #8682      +/-   ##
============================================
+ Coverage     45.30%   45.31%   +0.01%     
- Complexity     4073     4074       +1     
============================================
  Files           700      700              
  Lines         27045    27045              
  Branches       2894     2894              
============================================
+ Hits          12252    12255       +3     
+ Misses        13639    13637       -2     
+ Partials       1154     1153       -1     
Impacted Files Coverage Δ
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 53.52% <0.00%> (+2.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2650ef...b2c7361. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 3, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
59.6% 59.6% Duplication

@zhongjiajie zhongjiajie merged commit bf0cc6a into apache:dev Mar 3, 2022
@songjianet songjianet deleted the fix-home-page-i18n branch March 3, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][UI Next][V1.0.0-Alpha] Modified the system language, the chart text is not changed to Chinese as expected

4 participants