Skip to content

[Fix-8616][WorkFlowLineage] work flow lineage search result missing data#8684

Merged
caishunfeng merged 4 commits into
apache:devfrom
SbloodyS:bug_8616
Mar 4, 2022
Merged

[Fix-8616][WorkFlowLineage] work flow lineage search result missing data#8684
caishunfeng merged 4 commits into
apache:devfrom
SbloodyS:bug_8616

Conversation

@SbloodyS
Copy link
Copy Markdown
Member

@SbloodyS SbloodyS commented Mar 3, 2022

Purpose of the pull request

This pr will close #8616

Brief change log

  1. Refactor org.apache.dolphinscheduler.api.service.impl.WorkFlowLineageServiceImpl#queryWorkFlowLineageByCode.
  2. Fix the problem of missing upstream dependent data.
  3. Add query downstream dependency.
  4. Remove meaningless log output in dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskGroupServiceImpl.java.

This change added tests and can be verified as follows:

@SbloodyS SbloodyS closed this Mar 3, 2022
@SbloodyS SbloodyS reopened this Mar 3, 2022
Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #8684 (8a2cf9c) into dev (43fc7ec) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #8684      +/-   ##
============================================
- Coverage     45.30%   45.29%   -0.02%     
  Complexity     4073     4073              
============================================
  Files           700      700              
  Lines         27045    27050       +5     
  Branches       2894     2894              
============================================
- Hits          12252    12251       -1     
- Misses        13639    13645       +6     
  Partials       1154     1154              
Impacted Files Coverage Δ
...heduler/api/service/impl/TaskGroupServiceImpl.java 63.47% <ø> (-0.32%) ⬇️
...r/api/service/impl/WorkFlowLineageServiceImpl.java 33.33% <0.00%> (-2.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43fc7ec...8a2cf9c. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 4, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@caishunfeng caishunfeng merged commit 2ab8c1c into apache:dev Mar 4, 2022
@SbloodyS SbloodyS deleted the bug_8616 branch March 4, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [WorkFlowLineage] work flow lineage search result missing data

3 participants