Skip to content

[Feature-8369][Document]Add docs building test instructions in pydolphinscheduler DEVELOP.md#8693

Merged
zhongjiajie merged 1 commit into
apache:devfrom
EricGao888:Fix-8369
Mar 29, 2022
Merged

[Feature-8369][Document]Add docs building test instructions in pydolphinscheduler DEVELOP.md#8693
zhongjiajie merged 1 commit into
apache:devfrom
EricGao888:Fix-8369

Conversation

@EricGao888
Copy link
Copy Markdown
Member

@EricGao888 EricGao888 commented Mar 4, 2022

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 4, 2022

Codecov Report

Merging #8693 (4eb8bb7) into dev (e00727c) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #8693      +/-   ##
============================================
+ Coverage     40.21%   40.22%   +0.01%     
- Complexity     4375     4377       +2     
============================================
  Files           817      817              
  Lines         32676    32676              
  Branches       3637     3637              
============================================
+ Hits          13140    13144       +4     
+ Misses        18306    18304       -2     
+ Partials       1230     1228       -2     
Impacted Files Coverage Δ
...e/dolphinscheduler/remote/NettyRemotingClient.java 53.52% <0.00%> (+2.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e00727c...4eb8bb7. Read the comment docs.

Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add some suggestion about it

Comment thread dolphinscheduler-python/pydolphinscheduler/DEVELOP.md Outdated
Comment thread dolphinscheduler-python/pydolphinscheduler/DEVELOP.md Outdated
Comment thread dolphinscheduler-python/pydolphinscheduler/DEVELOP.md
Comment thread dolphinscheduler-python/pydolphinscheduler/DEVELOP.md Outdated
@EricGao888
Copy link
Copy Markdown
Member Author

I add some suggestion about it

I've resolved all the comments. CI is failing because Sonar Cloud server cannot be reached. Could you please take a look at it? Thx! @zhongjiajie
image

@zhongjiajie
Copy link
Copy Markdown
Member

I restart the failed test, it almost because of the random error

@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

8.9% 8.9% Coverage
14.4% 14.4% Duplication

@EricGao888
Copy link
Copy Markdown
Member Author

I restart the failed test, it almost because of the random error

@zhongjiajie I think it looks good now. The coverage and duplicate stuff reported by SonarCloud Code Analysis seems not related to this pr.

Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks and nice to see you again

@zhongjiajie zhongjiajie merged commit 4c1578a into apache:dev Mar 29, 2022
@EricGao888
Copy link
Copy Markdown
Member Author

LGTM. Thanks and nice to see you again

Cool, thx for help with review : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][Document] Add doc building test instruction in pydolphinscheduler DEVELOP.md

3 participants