[Fix-8624][UI-Next][V1.0.0-Alpha] Rectify the issue to display the timing form when clicking the timing button in the process definition page.#8704
Merged
songjianet merged 2 commits intoapache:devfrom Mar 5, 2022
Conversation
devosend
reviewed
Mar 5, 2022
| timingState.timingForm.startEndTime = [ | ||
| new Date(props.row.startTime), | ||
| new Date(props.row.endTime) | ||
| props.row.startTime? new Date(props.row.startTime) : new Date(), |
Contributor
There was a problem hiding this comment.
You can use props.row.crontab to determine whether timeForm init is needed. Beause timeForm.crontab and other's needs to be initialized.
Contributor
Author
There was a problem hiding this comment.
No problem. I'll improve that.
Contributor
|
LGTM |
|
SonarCloud Quality Gate failed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #8704 +/- ##
============================================
- Coverage 45.31% 45.30% -0.02%
Complexity 4075 4075
============================================
Files 700 700
Lines 27050 27050
Branches 2894 2894
============================================
- Hits 12258 12255 -3
- Misses 13636 13643 +7
+ Partials 1156 1152 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
This PR will close #8624 .
Brief change log
Verify this pull request
This change added tests and can be verified as follows: