[Improvement][Server] change quartz executor to be managed by Spring#8774
Merged
Conversation
|
SonarCloud Quality Gate failed. |
Codecov Report
@@ Coverage Diff @@
## dev #8774 +/- ##
============================================
- Coverage 45.34% 45.30% -0.04%
+ Complexity 4080 4075 -5
============================================
Files 702 702
Lines 27112 27109 -3
Branches 2897 2897
============================================
- Hits 12293 12281 -12
- Misses 13665 13678 +13
+ Partials 1154 1150 -4
Continue to review full report at Codecov.
|
kezhenxu94
approved these changes
Mar 9, 2022
SbloodyS
added a commit
to SbloodyS/dolphinscheduler
that referenced
this pull request
Mar 10, 2022
[Docs][UI-Next] Add js-cookie license. (apache#8762) [Fix-8744][standalone-server] start standalone server failed (apache#8747) [Fix] [ui] Fixed the re-upload function of the Resource Management menu apache#8764 (apache#8763) * [fix] [ui] Fixed the re-upload function of the Resource Management menu * Modify resource file list and sub-file front-end code * Modify udF resource file list and subfile front-end code * Fix modified page does not dynamically update content, added V-if judgment * [fix] [ui] Fixed the re-upload function of the Resource Management menu * Modify resource file list and sub-file front-end code * Modify udF resource file list and subfile front-end code * Fix modified page does not dynamically update content, added V-if judgment * Fix duplicate ID problem Co-authored-by: wangqiang <wangqiang@coocaa.com> [Feature-8735][UI Next][V1.0.0-Alpha] Added the form of the EMR task. (apache#8766) * add two icons * developed the form of the emr task [Fix][UI Next][V1.0.0-Alpha] Fix error when deployed to nginx after compilation (apache#8767) [Fix][UI-Next][V1.0.0-Alpha] Fix user login error (apache#8773) * fix user login error * logout clear cookie [Fix-8757][UI Next][V1.0.0-Alpha] Added the text button into the form of the task. (apache#8775) * fix this issue * restore the lodash.min.js [python] Add LICENSE and NOTICE to python dist package (apache#8768) * Add LICENSE and NOTICE to Python API * Add new license dir `python-api-license` to keep all Python API's LICENSE files * Change LICENSE in distribute package * Add content about should add LICENSE when new dependence adding change quartz executor to be managed by spring (apache#8774) Co-authored-by: caishunfeng <534328519@qq.com> [Fix][data-quality] change data-quality task main jar path (apache#8752) * feat(data-quality) change data-quality task main jar path * feat(data-quality) change data-quality task main jar path Co-authored-by: zixi0825 <sunzhaohe@linklogis.com> [Fix][UI Next][V1.0.0-Alpha] Fix workflow duplicate key error bug (apache#8782) remove testCreateDuplicateTenant fix error fix error test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test feature_8727
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
QuartzExecutorto be managed by SpringBrief change log
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/quartz/QuartzExecutor.java, and implete bydolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/quartz/impl/QuartzExecutorImpl.java.Verify this pull request
This pull request is already covered by existing tests, such as
dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/SchedulerServiceTest.java.Manually verified the change by testing locally is OK.