Skip to content

[Feature][dolphinscheduler-api] Return domain object after creating success#8825

Merged
ruanwenjun merged 1 commit into
apache:devfrom
ouyangyewei429:issue/#8817
Mar 13, 2022
Merged

[Feature][dolphinscheduler-api] Return domain object after creating success#8825
ruanwenjun merged 1 commit into
apache:devfrom
ouyangyewei429:issue/#8817

Conversation

@ouyangyewei429
Copy link
Copy Markdown
Contributor

to #8817

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #8825 (b3a8b2d) into dev (97a0eed) will decrease coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #8825      +/-   ##
============================================
- Coverage     45.30%   45.30%   -0.01%     
+ Complexity     4076     4075       -1     
============================================
  Files           702      702              
  Lines         27110    27115       +5     
  Branches       2897     2897              
============================================
+ Hits          12283    12284       +1     
- Misses        13674    13677       +3     
- Partials       1153     1154       +1     
Impacted Files Coverage Δ
...eduler/api/service/impl/AlertGroupServiceImpl.java 90.80% <50.00%> (-0.87%) ⬇️
...i/service/impl/AlertPluginInstanceServiceImpl.java 65.95% <100.00%> (+0.36%) ⬆️
...e/dolphinscheduler/remote/NettyRemotingClient.java 50.70% <0.00%> (-2.12%) ⬇️
...api/service/impl/ProcessDefinitionServiceImpl.java 31.90% <0.00%> (-0.03%) ⬇️
...inscheduler/api/service/impl/UsersServiceImpl.java 74.89% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97a0eed...b3a8b2d. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 4 Code Smells

1.8% 1.8% Coverage
1.1% 1.1% Duplication

Copy link
Copy Markdown
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit 5fa1c4e into apache:dev Mar 13, 2022
@ruanwenjun
Copy link
Copy Markdown
Member

Thanks for your patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants