Skip to content

[Improvement-8874][API] Fix create&update workflow cron APIs, verify the end time must bigger than start time#8871

Merged
caishunfeng merged 1 commit into
apache:devfrom
Tianqi-Dotes:fix/cron-time-verify
Mar 14, 2022
Merged

[Improvement-8874][API] Fix create&update workflow cron APIs, verify the end time must bigger than start time#8871
caishunfeng merged 1 commit into
apache:devfrom
Tianqi-Dotes:fix/cron-time-verify

Conversation

@Tianqi-Dotes
Copy link
Copy Markdown
Member

Purpose of the pull request

This PR fix create & update workflow cron APIs, verify the end time must be bigger than the start time

Brief change log

fix workflow cron time verification

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 14, 2022

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.29%. Comparing base (a9c9eb0) to head (8778000).
⚠️ Report is 2818 commits behind head on dev.

Files with missing lines Patch % Lines
...heduler/api/service/impl/SchedulerServiceImpl.java 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8871      +/-   ##
============================================
- Coverage     45.31%   45.29%   -0.03%     
- Complexity     4077     4081       +4     
============================================
  Files           702      702              
  Lines         27111    27177      +66     
  Branches       2897     2909      +12     
============================================
+ Hits          12285    12309      +24     
- Misses        13674    13706      +32     
- Partials       1152     1162      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Tianqi-Dotes Tianqi-Dotes changed the title fix create&update workflow cron APIs, verify the end time must bigger than start time [Improvement-8874][API] Fix create&update workflow cron APIs, verify the end time must bigger than start time Mar 14, 2022
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@caishunfeng caishunfeng merged commit 1f83140 into apache:dev Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants