Skip to content

[Fix][UI Next][V1.0.0-Alpha] The problem of multi-language support in FeiShu alert instance.#8981

Merged
CalvinKirs merged 1 commit into
apache:devfrom
songjianet:fix-alerm-instance-feishu
Mar 18, 2022
Merged

[Fix][UI Next][V1.0.0-Alpha] The problem of multi-language support in FeiShu alert instance.#8981
CalvinKirs merged 1 commit into
apache:devfrom
songjianet:fix-alerm-instance-feishu

Conversation

@songjianet
Copy link
Copy Markdown
Member

@songjianet songjianet commented Mar 18, 2022

Purpose of the pull request

#8962

image
image

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@songjianet songjianet added bug Something isn't working UI ui and front end related labels Mar 18, 2022
@songjianet songjianet self-assigned this Mar 18, 2022
Copy link
Copy Markdown
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #8981 (52a53ee) into dev (045ef75) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 52a53ee differs from pull request most recent head 3c707f3. Consider uploading reports for the commit 3c707f3 to get more accurate results

@@             Coverage Diff              @@
##                dev    #8981      +/-   ##
============================================
- Coverage     39.77%   39.75%   -0.02%     
+ Complexity     4265     4262       -3     
============================================
  Files           808      808              
  Lines         32550    32550              
  Branches       3649     3649              
============================================
- Hits          12946    12941       -5     
- Misses        18378    18380       +2     
- Partials       1226     1229       +3     
Impacted Files Coverage Δ
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 50.70% <0.00%> (-2.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 045ef75...3c707f3. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
100.0% 100.0% Duplication

@CalvinKirs CalvinKirs merged commit 7ca5cdd into apache:dev Mar 18, 2022
@songjianet songjianet deleted the fix-alerm-instance-feishu branch March 18, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants