[Fix][UI Next][V1.0.0-Alpha] Fix the state column of task instance ta…#8987
Merged
Conversation
…ble displays error.
Member
|
|
Codecov Report
@@ Coverage Diff @@
## dev #8987 +/- ##
============================================
- Coverage 39.77% 39.76% -0.01%
+ Complexity 4265 4264 -1
============================================
Files 808 808
Lines 32550 32550
Branches 3649 3649
============================================
- Hits 12946 12945 -1
Misses 18378 18378
- Partials 1226 1227 +1
Continue to review full report at Codecov.
|
SbloodyS
reviewed
Mar 18, 2022
| { | ||
| size: '18px', | ||
| style: 'position: relative; top: 7.5px; left: 7.5px', | ||
| class: stateIcon.classNames |
Member
There was a problem hiding this comment.
The WorkflowE2ETest using class success to verify the process instance success state. Removing it would lead to the WorkflowE2ETest failed.
Member
Author
There was a problem hiding this comment.
I will add the class by the task type.Such as SUBMITTED_SUCCESS will be submitted_success expect FAILURE which corresponds to failed.
…task instance table and workflow instance.
|
SonarCloud Quality Gate failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
This pull request fixs the state column of task instance table displays error.
Releated issues
close #8982