Skip to content

[Fix][UI Next][V1.0.0-Alpha] Fix the alarm instance management edit button floating prompt error.#9005

Merged
CalvinKirs merged 1 commit into
apache:devfrom
songjianet:fix-alarm-instance-edit-btn
Mar 19, 2022
Merged

[Fix][UI Next][V1.0.0-Alpha] Fix the alarm instance management edit button floating prompt error.#9005
CalvinKirs merged 1 commit into
apache:devfrom
songjianet:fix-alarm-instance-edit-btn

Conversation

@songjianet
Copy link
Copy Markdown
Member

@songjianet songjianet commented Mar 19, 2022

Purpose of the pull request

close #9003

image
image

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@songjianet songjianet added bug Something isn't working UI ui and front end related labels Mar 19, 2022
@songjianet songjianet self-assigned this Mar 19, 2022
Copy link
Copy Markdown
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #9005 (c81d76d) into dev (7d94ada) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev    #9005   +/-   ##
=========================================
  Coverage     39.75%   39.75%           
  Complexity     4262     4262           
=========================================
  Files           808      808           
  Lines         32551    32551           
  Branches       3649     3649           
=========================================
  Hits          12941    12941           
  Misses        18381    18381           
  Partials       1229     1229           
Impacted Files Coverage Δ
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 83.60% <0.00%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d94ada...c81d76d. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
100.0% 100.0% Duplication

@CalvinKirs CalvinKirs merged commit 5c5f737 into apache:dev Mar 19, 2022
@songjianet songjianet deleted the fix-alarm-instance-edit-btn branch March 19, 2022 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][UI Next][V1.0.0-Alpha] Alarm instance management edit button floating prompt error.

4 participants