Skip to content

[Fix][UI Next][V1.0.0-Alpha] Fix there is a problem with the language support of the PagerDuty alarm instance.#9027

Merged
CalvinKirs merged 1 commit into
apache:devfrom
songjianet:fix-alarm-instance-PagerDuty
Mar 20, 2022
Merged

[Fix][UI Next][V1.0.0-Alpha] Fix there is a problem with the language support of the PagerDuty alarm instance.#9027
CalvinKirs merged 1 commit into
apache:devfrom
songjianet:fix-alarm-instance-PagerDuty

Conversation

@songjianet
Copy link
Copy Markdown
Member

Purpose of the pull request

close #9001

image
image

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@songjianet songjianet added bug Something isn't working UI ui and front end related labels Mar 20, 2022
@songjianet songjianet self-assigned this Mar 20, 2022
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #9027 (124e30b) into dev (7114c15) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #9027      +/-   ##
============================================
- Coverage     39.77%   39.75%   -0.02%     
+ Complexity     4265     4263       -2     
============================================
  Files           808      808              
  Lines         32551    32551              
  Branches       3649     3649              
============================================
- Hits          12947    12942       -5     
- Misses        18375    18381       +6     
+ Partials       1229     1228       -1     
Impacted Files Coverage Δ
...olphinscheduler/rpc/remote/NettyServerHandler.java 69.04% <0.00%> (-11.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7114c15...124e30b. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
100.0% 100.0% Duplication

@CalvinKirs CalvinKirs merged commit 7ada204 into apache:dev Mar 20, 2022
Copy link
Copy Markdown
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songjianet songjianet deleted the fix-alarm-instance-PagerDuty branch March 22, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][UI Next][V1.0.0-Alpha] There is a problem with the language support of the PagerDuty alarm instance.

4 participants