Skip to content

[Fix][UI Next][V1.0.0-Alpha] Fix there are multiple hover prompts.#9116

Merged
calvinjiang merged 3 commits into
apache:devfrom
songjianet:fix-workflow-definition-table
Mar 23, 2022
Merged

[Fix][UI Next][V1.0.0-Alpha] Fix there are multiple hover prompts.#9116
calvinjiang merged 3 commits into
apache:devfrom
songjianet:fix-workflow-definition-table

Conversation

@songjianet
Copy link
Copy Markdown
Member

Purpose of the pull request

close #9115

image

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@songjianet songjianet added bug Something isn't working UI ui and front end related labels Mar 23, 2022
@songjianet songjianet self-assigned this Mar 23, 2022
Amy0104
Amy0104 previously approved these changes Mar 23, 2022
Copy link
Copy Markdown
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #9116 (339ec26) into dev (5762a5c) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 339ec26 differs from pull request most recent head 64f2a2b. Consider uploading reports for the commit 64f2a2b to get more accurate results

@@             Coverage Diff              @@
##                dev    #9116      +/-   ##
============================================
- Coverage     40.28%   40.27%   -0.02%     
+ Complexity     4366     4364       -2     
============================================
  Files           808      808              
  Lines         32547    32547              
  Branches       3646     3646              
============================================
- Hits          13113    13109       -4     
- Misses        18208    18210       +2     
- Partials       1226     1228       +2     
Impacted Files Coverage Δ
...e/dolphinscheduler/remote/NettyRemotingClient.java 50.70% <0.00%> (-2.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5762a5c...64f2a2b. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@calvinjiang calvinjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calvinjiang calvinjiang merged commit c69d9f8 into apache:dev Mar 23, 2022
@songjianet songjianet deleted the fix-workflow-definition-table branch March 24, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug-FE][UI Next][V1.0.0-Alpha] There are multiple hover prompts.

4 participants