Skip to content

[python] Fix change exists pd attribute user error#9140

Merged
caishunfeng merged 2 commits into
apache:devfrom
zhongjiajie:py-bug-ch-attr-user
Mar 24, 2022
Merged

[python] Fix change exists pd attribute user error#9140
caishunfeng merged 2 commits into
apache:devfrom
zhongjiajie:py-bug-ch-attr-user

Conversation

@zhongjiajie
Copy link
Copy Markdown
Member

  • Remove attribute from class ProcessDefinition, cause it should to
    object User instead of object ProcessDefinition.
  • Grant project to user if attribute user change for exists ProcessDefinition

close: #8751

* Remove attribute from class ProcessDefinition, cause it should to
  object User instead of object ProcessDefinition.
* Grant project to user if attribute user change for exists ProcessDefinition

close: apache#8751
@zhongjiajie zhongjiajie self-assigned this Mar 23, 2022
@zhongjiajie zhongjiajie added bug Something isn't working Pyscheduler labels Mar 23, 2022
@zhongjiajie zhongjiajie reopened this Mar 24, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 24, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.27%. Comparing base (23b2450) to head (fabc39e).
⚠️ Report is 2698 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #9140   +/-   ##
=========================================
  Coverage     40.27%   40.27%           
- Complexity     4363     4365    +2     
=========================================
  Files           808      808           
  Lines         32547    32569   +22     
  Branches       3646     3650    +4     
=========================================
+ Hits          13108    13118   +10     
- Misses        18210    18220   +10     
- Partials       1229     1231    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@zhongjiajie
Copy link
Copy Markdown
Member Author

PTAL @devosend @jieguangzhou thanks.

Copy link
Copy Markdown
Contributor

@devosend devosend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@jieguangzhou jieguangzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng merged commit 5289b09 into apache:dev Mar 24, 2022
@zhongjiajie zhongjiajie deleted the py-bug-ch-attr-user branch March 24, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Pyscheduler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [python] Change param user, queue do no work in ProcessDefinition

5 participants