[Improve][CI] improve ci checking#9325
Conversation
| paths-ignore: | ||
| - 'docs/**' | ||
| push: | ||
| branches: | ||
| - dev | ||
| paths-ignore: | ||
| - 'docs/**' |
There was a problem hiding this comment.
I remember I told you that this can not be added because if the workflow is skipped, the PRs cannot be merged
There was a problem hiding this comment.
Sorry,I forgot this. I'll see if i can fix it. If not i will remove it. @kezhenxu94
There was a problem hiding this comment.
I try to modify e2e-test with https://github.com/dorny/paths-filter#examples and https://github.com/dorny/paths-filter/issues/97. Please check if this is correct. If not i will remove it. Thanks. @kezhenxu94
There was a problem hiding this comment.
It seems like dorny/paths-filter@v2 is not allowed to be used in apache/dolphinscheduler. Sad...
There was a problem hiding this comment.
I have submitted a request to apache infra to see if this plugin can be enable. https://issues.apache.org/jira/browse/INFRA-23069
In the mean time, I will mark this pr as draft until this plugin is enable or i can find another way to solve this problem.
There was a problem hiding this comment.
@SbloodyS you can use this getsentry/paths-filter@v2 instead, seems they have the same functionalities and this is approved already by infra team as I know
There was a problem hiding this comment.
@SbloodyS you can use this getsentry/paths-filter@v2 instead, seems they have the same functionalities and this is approved already by infra team as I know
Wow, It seems working. I will do more tests to verify it. Thanks.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #9325 +/- ##
============================================
- Coverage 39.98% 39.97% -0.02%
+ Complexity 4376 4372 -4
============================================
Files 822 822
Lines 32921 32921
Branches 3656 3656
============================================
- Hits 13165 13161 -4
- Misses 18527 18532 +5
+ Partials 1229 1228 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@kezhenxu94 @zhongjiajie Please review. Thanks. |
|
Kudos, SonarCloud Quality Gate passed!
|
| name: Build | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 30 | ||
| needs: [ build ] |
There was a problem hiding this comment.
Did we miss job paths-filter dependent here?
There was a problem hiding this comment.
It does not need to. It already exists in steps.run.
There was a problem hiding this comment.
@zhongjiajie we don't need explicit dependent here, result depends on build, build depends on paths-filter, so result depends on paths-filter implicitly
There was a problem hiding this comment.
Thanks for the clarification.
4 participants
Purpose of the pull request
docspath exclude fromunit-testande2e-testandbackenddolphinscheduler-uianddolphinscheduler-ui-nextpath exclude frombackenddocspath include fromdocs-testfind ./docsindocs-test