Add pull request checks#501
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new
PR ChecksGitHub Actions workflow for pull requests.The workflow introduces two pre-merge check groups:
Go Basic Checksgo.mod.gofmtfor Go files changed by the pull request.go vet ./...across the repository.golangci-lintwith a 10 minute timeout.Generated Artifacts Checkmake manifests generate.git diff --exit-codeto make sure generated files are committed.Motivation
The project currently has release and license workflows, but pull requests do not have a dedicated quality gate for Go code and generated operator artifacts.
For a Kubernetes operator, generated files are part of the reviewed source of truth. API, RBAC, webhook, CRD, and deepcopy changes can easily be missed if the generated artifacts are not checked before merge.
Notes
The
gofmtcheck is intentionally scoped to Go files changed by the pull request. This avoids blocking unrelated pull requests on existing formatting issues in untouched files while still enforcing formatting for new changes.This PR does not add unit tests or envtest execution.
Validation
Validated locally with:
ruby -e "require 'yaml'; YAML.load_file('.github/workflows/pr-checks.yml')" go vet ./... make manifests generate git diff --exit-code -- config/crd/bases helm-charts/doris-operator/crds api/doris api/disaggregated