Skip to content

Conversation

@robll-v1
Copy link
Contributor

@robll-v1 robll-v1 commented Nov 12, 2025

Versions

  • [ √] dev
  • [ √] 4.x
  • 3.x
  • 2.1

Languages

  • [√ ] Chinese
  • [ √] English

Docs Checklist

  • Checked by AI
  • Test Cases Built

@robll-v1 robll-v1 requested a review from zclllyybb as a code owner November 12, 2025 13:10
Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 参考下其它文档的格式
  2. 添加sidebar
  3. 需要中文+英文。dev+4.x

@zclllyybb
Copy link
Contributor

在 pr content里link过来对应的 code PR

@robll-v1
Copy link
Contributor Author

code pr : apache/doris#57893

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

中文这里整体再写下


| Parameter | Description |
| -- | -- |
| `<x>` | It returns the century of the corresponding date and supports error type handling. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里应该是参数,而不是返回值


The century corresponding to the given date

## Special Cases
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

参考下其他函数的文档格式哈,这块应该是合到上面的 Return Value 里面的

@linrrzqqq
Copy link
Contributor

还需要4.x 版本的文档(doris-website/versioned_docs/version-4.x && doris-website/i18n/zh-CN/docusaurus-plugin-content-docs/version-4.x && sidebar in doris-website/versioned_sidebars/version-4.x-sidebars.json

sidebars.ts Outdated
'sql-manual/sql-functions/scalar-functions/numeric-functions/cbrt',
'sql-manual/sql-functions/scalar-functions/numeric-functions/ceil',
'sql-manual/sql-functions/scalar-functions/numeric-functions/conv',
'sql-manual/sql-functions/scalar-functions/numeric-functions/century',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

按字典序排列


## 语法
```sql
CENTURY(<date_or_time_expr>) [AS <alias>]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to add [AS <alias>]. keep structure same between same docs in different branch

CENTURY(<date_or_time_expr>) [AS <alias>]
```

##参数
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a space here to make it a title

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont add 3.x docs. you should add 4 docs: 2 langs in dev, 2 langs in 4.x

@@ -0,0 +1,59 @@
---
{
"title": "世纪 (century)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont need Chinese translation here.

Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你的不同几个文档格式没有对齐,请处理成相同的格式。

Copy link
Contributor Author

@robll-v1 robll-v1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix some format and fix the sidebars,This‘s my problem.

Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zclllyybb zclllyybb merged commit c1d9726 into apache:master Nov 26, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants