[fix] correct column names in aggregate model doc examples#3670
Merged
morningman merged 3 commits intoMay 20, 2026
Conversation
Two example errors in the aggregate data model doc: - The `SELECT * FROM example_tbl_agg` output header used `last_visit_date` and `max_dwell_time`, but the table is defined with `last_visit_dt` and `max_dwell`. - The `aggstate` table is defined with columns `k1, v1, v2`, but the intermediate-result section queried non-existent `k2` / `k3`. Corrected to `v1` / `v2`. Applied across all affected EN and Chinese versions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The CI pipeline no longer builds these legacy versions, so changes there cannot be merged. Restore those files to their base state.
The previous commit's git-add-all unintentionally included two untracked working files. Remove them from the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two code-example errors in the aggregate data model doc (
table-design/data-model/aggregate.md):example_tbl_aggoutput mismatch — theSELECT * FROM example_tbl_aggresult header showedlast_visit_date/max_dwell_time, but the table DDL defines those columns aslast_visit_dt/max_dwell. Corrected the output header to match the DDL.aggstatenon-existent columns — the tableaggstateis defined with columnsk1, v1, v2, but the "retain intermediate results" section used non-existentk2/k3insum_union/sum_merge/group_concat_union/group_concat_merge. Corrected tov1/v2(the earliermergeexample already correctly usesv2).Applied across all affected versions (EN: next + 2.0/2.1/3.x/4.x; ZH: next + 2.1/3.x/4.x).
Test plan
example_tbl_aggDDL column names vs theSELECT *output headeraggstateDDL columns (k1, v1, v2) vs the queries;sum_*maps to theSUMcolumnv1,group_concat_*maps to theagg_state<group_concat>columnv2