[fix] correct doris_fe_txn_counter metric label typo and description#3676
Merged
Conversation
Two errors in the metrics doc for the `doris_fe_txn_counter` metric, verified against the FE source (MetricRepo.java): - The `type` label `succes` is a doc typo; the metric emits `success`. - The `type="begin"` row was described as "committed transactions", but it counts begun transactions (FE source: "counter of beginning transactions"). Corrected the EN and Chinese descriptions. Applied across all affected EN and Chinese versions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two errors in the metrics doc (
admin-manual/maint-monitor/metrics.md) for thedoris_fe_txn_countermetric, both verified against the FE sourceMetricRepo.java:typelabel is writtensucces; the metric actually emitssuccess(COUNTER_TXN_SUCCESS.addLabel(new MetricLabel("type", "success"))). Fixed the doc typo.type="begin"row was described as "Number of committed transactions" (Chinese: "提交的事务数量"). Thebegincounter counts begun transactions (FE source description: "counter of beginning transactions"); commit corresponds tosuccess. Corrected to "Number of begun transactions" / "开始的事务数量". The BE metricdoris_be_stream_load_txn_request {type="begin"}in the same doc already correctly says "begun".Applied across all affected versions: EN (next + 4.x) and Chinese (next + 2.1/3.x/4.x).
Test plan
begincounter semantics againstapache/dorisFEMetricRepo.java