[fix] correct restore_reset_index_id example value in CCR config doc#3680
Merged
Merged
Conversation
The FE Configuration example showed `restore_reset_index_id = true`, contradicting the rest of the doc: the parameter table and the tuning combinations table both say it should be `false` for synced tables with inverted/bitmap indexes, and the FE default is `false` (verified against Config.java). Changed the example to `false`. Applied across all affected EN and Chinese versions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the CCR config doc (
admin-manual/data-admin/ccr/config.md), the "FE Configuration" example showed:This contradicts the rest of the same doc — the parameter reference table and the "Common Tuning Combinations" table both say
restore_reset_index_idshould befalsefor synced tables with inverted/bitmap indexes. The FE default is alsofalse(verified againstConfig.java:public static boolean restore_reset_index_id = false). No scenario in the doc recommendstrue.Changed the example value to
false. Applied across all affected versions: EN (next + 2.1/3.x/4.x) and Chinese (next + 2.1/3.x/4.x).Test plan
restore_reset_index_id = falseagainstapache/dorisConfig.javafalse