[fix] keep Ask Me modal header below the sticky navbar#3700
Merged
Conversation
The Kapa modal was vertically centered with only a 2rem top inset, so when content was tall the modal header slid under the 64px sticky NavbarNext. Anchor the modal to the top with an 80px (navbar + 16px gap) inset and cap max-height accordingly so the body still scrolls inside the modal. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Drop the bundled Montserrat font family along with all individual-weight .otf assets for Montserrat / MontserratAlternates / NotoSansSC — only the variable-font files for Inter and NotoSansSC are actually loaded by @font-face. The two components that referenced Montserrat (PageBanner, AchievementBanner) have no remaining imports anywhere in the site, so remove them too. Also drop the commented MiSans / Google Fonts entries in docusaurus.config.js and the unreachable 'MiSans Latin' fallback in the English stack. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Bundle JetBrainsMono-VariableFont_wght.ttf so the Next homepage / Why- Doris mono styling (hero titles, benchmark figures, eyebrows, etc.) is consistent for every visitor instead of relying on whether their system ships JetBrains/IBM Plex Mono. Move all @font-face declarations and font stacks into a single :root block in src/scss/custom.scss, exposing --font-sans-en / --font-sans-zh / --font-mono and overriding Infima's --ifm-font-family-base and --ifm-font-family-monospace so Docusaurus code blocks pick up the same mono. The html[lang] selectors now just point --font-family-base at the right sans var. Across ~15 component SCSS files in home-next/, why-doris-next/, and use-cases-next/, drop the per-component --hn-sans / --kf-mono / --bn-sans / --un-mono / --dn-sans / etc. declarations (each redefining the same stack) and the inline 'JetBrains Mono', ... / 'Inter', ... strings, replacing every usage with var(--font-family-base) or var(--font-mono). _typography.scss's $font-sans / $font-mono now alias the global CSS vars instead of holding their own stacks. Also self-host Inter in the embedded what-is-apache-doris-intro.html animation (was pulling from fonts.googleapis.com) and switch the summit-modal inline style to var(--font-family-base). Net: one place to change a font, three self-hosted variable fonts cover the whole site, no external font requests. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The deploy workflows ran update_github_info.js unauthenticated, hitting the 60/h rate limit on shared Actions runner IPs. When the API returned a rate-limit response, the script silently swallowed the missing field and exited 0, so the site kept shipping the stale 13.1k value. Pass github.token through to the build step and make the script exit non-zero on any API failure so a stale star count fails the deploy instead of going out unnoticed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Kapa modal was vertically centered with only a 2rem top inset, so when content was tall the modal header slid under the 64px sticky NavbarNext. Anchor the modal to the top with an 80px (navbar + 16px gap) inset and cap max-height accordingly so the body still scrolls inside the modal.