[fix] remove aggregate-functions bleed from Analytic (Window) Functions sidebar#3703
Closed
boluor wants to merge 1 commit into
Closed
[fix] remove aggregate-functions bleed from Analytic (Window) Functions sidebar#3703boluor wants to merge 1 commit into
boluor wants to merge 1 commit into
Conversation
…ns sidebar The 'Analytic (Window) Functions' category in sidebars.ts (current/dev) and versioned_sidebars/version-4.x-sidebars.json wrongly listed 67 aggregate-functions/* entries (any-value through window-funnel) in addition to the 11 genuine window-functions/* entries. As a result, those aggregate-functions appeared twice in the sidebar (once in 'Aggregate Functions' and once in 'Analytic (Window) Functions'). version-3.x and version-2.1 sidebars are correctly organized with no overlap; this PR restores the same convention for current/dev and 4.x. Categorization follows the prevailing industry convention: - Databricks and ClickHouse keep aggregate functions and window functions in separate categories (no cross-listing). - Snowflake double-categorizes a subset of aggregates that support OVER(), but even Snowflake does NOT list WINDOW_FUNNEL or TOPN/TOP_K under window functions. After this change: - 'Aggregate Functions': 71 items (unchanged) - 'Analytic (Window) Functions': 11 items (the 11 SQL-standard window functions: overview, cume-dist, dense-rank, first-value, lag, last-value, lead, ntile, percent-rank, rank, row-number) Aggregate functions that can be used with OVER() still document this usage inside their own page (e.g., bool-or.md has a '### Window function:' subsection).
Contributor
Author
|
Closing per team feedback — the dual-listing (aggregate functions also indexed under Analytic (Window) Functions) is the intended design for the current/dev and 4.x sidebars. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Analytic (Window) Functionscategory insidebars.ts(current/dev) andversioned_sidebars/version-4.x-sidebars.jsonwrongly listed 67aggregate-functions/*entries (any-valuethroughwindow-funnel) in addition to the 11 genuinewindow-functions/*entries. As a result those aggregate functions appeared twice in the sidebar — once correctly under `Aggregate Functions`, and once again under `Analytic (Window) Functions`.version-3.xandversion-2.1sidebars are correctly organized with no overlap; this PR restores the same convention forcurrent/devand4.x.After this change
overview,cume-dist,dense-rank,first-value,lag,last-value,lead,ntile,percent-rank,rank,row-number)Aggregate functions that can be used with `OVER (PARTITION BY ...)` continue to document this usage inside their own page (e.g., `bool-or.md` has a `### Window function:` subsection).
Categorization rationale
Industry survey of the same question:
windowFunnelis in Parametric aggregate functions;topKis in Aggregate functionsSo even the most permissive convention (Snowflake) would not place `WINDOW_FUNNEL`/`TOPN` (or `SEQUENCE_MATCH`, `RETENTION`, `BITMAP_AGG`, etc.) under window functions. The bleed in 4.x was an unintended copy-paste — not a deliberate dual-classification. This PR matches Doris's own pre-existing 3.x / 2.1 convention and ClickHouse / Databricks.
Test plan