[fix](doc) note that DATE_TRUNC time_unit must be a string constant#3734
Merged
Merged
Conversation
DATE_TRUNC accepts both `(<datetime>, <time_unit>)` and `(<time_unit>, <datetime>)`, but the time unit must be a string constant — it cannot be a column or non-constant expression. Users hit "the ... parameter of date_trunc function must be a string constant" when passing a column there. Note this constraint in the time_unit parameter description on the current/4.x EN and zh pages. Reported in apache#2673. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DATE_TRUNCaccepts both argument orders —(<datetime>, <time_unit>)and(<time_unit>, <datetime>)— but the time unit must be a string constant; it cannot be a column or a non-constant expression. Passing a column there fails withthe ... parameter of date_trunc function must be a string constant.Added that constraint to the
<time_unit>parameter description on the current/4.x EN and zh pages so the requirement is explicit.Reported in #2673.
Test plan
DateTrunc.checkLegalityBeforeTypeCoercionrequires a string-literal time unit).Closes #2673