Skip to content

[fix](ci) filter retired versions from build-check onlyIncludeVersions #3742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 1 commit into from
May 22, 2026
+35 −3
Merged

[fix](ci) filter retired versions from build-check onlyIncludeVersions #3742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 35 additions & 3 deletions .github/workflows/build-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,15 +156,47 @@ jobs:
esac
done <<< "$CHANGED_FILES"

# Build the set of versions Docusaurus actually builds:
# `current` (the dev/unreleased version) plus everything in versions.json.
# Older version dirs (e.g. version-1.2, version-2.0) may still exist on
# disk but be absent from versions.json — touching them must not poison
# onlyIncludeVersions, which would fail the build with "unknown versions".
ACTIVE_VERSIONS=$(jq -r '.[]' versions.json | tr '\n' ',' | sed 's/,$//')
ACTIVE_VERSIONS="current,${ACTIVE_VERSIONS}"
echo "Active versions (current + versions.json): $ACTIVE_VERSIONS"

# Deduplicate versions
if [ "$NEED_FULL_BUILD" = "true" ]; then
# Structural changes: build all active versions
DOCS_VERSIONS=""
echo "Structural changes detected, will build ALL versions."
elif [ -n "$VERSIONS" ]; then
# Only doc content changes: build only affected versions
DOCS_VERSIONS=$(echo "$VERSIONS" | tr ',' '\n' | sort -u | grep -v '^$' | tr '\n' ',' | sed 's/,$//')
echo "Doc-only changes detected for versions: $DOCS_VERSIONS"
# Only doc content changes: build only affected versions.
# Intersect detected versions with the active set so that edits to
# retired version dirs (e.g. version-1.2) don't break the build.
RAW_VERSIONS=$(echo "$VERSIONS" | tr ',' '\n' | sort -u | grep -v '^$')
DOCS_VERSIONS=""
SKIPPED_VERSIONS=""
for v in $RAW_VERSIONS; do
if echo ",$ACTIVE_VERSIONS," | grep -q ",$v,"; then
DOCS_VERSIONS="${v},$DOCS_VERSIONS"
else
SKIPPED_VERSIONS="${v},$SKIPPED_VERSIONS"
fi
done
DOCS_VERSIONS=$(echo "$DOCS_VERSIONS" | sed 's/,$//')
SKIPPED_VERSIONS=$(echo "$SKIPPED_VERSIONS" | sed 's/,$//')
if [ -n "$SKIPPED_VERSIONS" ]; then
echo "Ignoring changes to retired/unknown versions: $SKIPPED_VERSIONS"
fi
if [ -z "$DOCS_VERSIONS" ]; then
# Everything we detected was retired/unknown; fall back to a
# minimal build so the workflow still validates the site.
DOCS_VERSIONS="4.x"
echo "All detected versions were retired/unknown, doing minimal build with '4.x' only."
else
echo "Doc-only changes detected for versions: $DOCS_VERSIONS"
fi
else
# No versioned doc changes (e.g., only blog, community, or scripts).
# Blog and community plugins are always compiled by Docusaurus
Expand Down
Loading