[fix](sql-functions) provide setup data for BITMAP_HASH / BITMAP_UNION examples#3900
Open
boluor wants to merge 1 commit into
Open
[fix](sql-functions) provide setup data for BITMAP_HASH / BITMAP_UNION examples#3900boluor wants to merge 1 commit into
boluor wants to merge 1 commit into
Conversation
…N examples Both bitmap example pages query tables that the older copies never define. - bitmap-hash (dev + 3.x + 2.1, EN+ZH): these copies still showed the old `words` example with an unreproducible expected count (33263478) and no table. Port the version-4.x rewrite: a concrete `words` table (6 rows, 4 distinct) with the matching reproducible result (4), plus the note that a real-scale corpus returns far larger numbers. (4.x already has this.) - bitmap-union (3.x + 2.1, EN+ZH): the example reads an aggregate-model `pv_bitmap` (the page documents the table at the bottom) but never creates it. Add a runnable `-- setup` that builds the aggregate table (user_id BITMAP BITMAP_UNION, AGGREGATE KEY(dt,page)) and loads the to_bitmap rows, so the dt/page result and the dedup count (3) reproduce. An aggregate model is required here — a duplicate-model table would not collapse to the two rows the doc prints. (dev/4.x already have setup.) Verified end-to-end on fresh single-BE clusters — 3.1.4, 2.1.11, and the local master daily build — every touched example reproduces the doc's printed output cell-for-cell (F0 on every version, EN and ZH). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both bitmap example pages query tables that the older copies never define, so a reader who runs the examples hits
table does not exist.wordsexample with an unreproducible expected count (33263478) and no table behind it. Port the version-4.x rewrite — a concretewordstable (6 rows, 4 distinct) with the matching reproducible result (4), plus the note that a real-scale corpus returns far larger numbers. (4.x is unchanged.)pv_bitmap(the page documents that table near the bottom) but never creates it. Add a runnable-- setupthat builds the aggregate table (user_id BITMAP BITMAP_UNION,AGGREGATE KEY(dt,page)) and loads theto_bitmaprows, so the dt/page result and the dedup count (3) reproduce. An aggregate model is required — a duplicate-model table would not collapse to the two rows the doc prints. (dev/4.x already carry setup.)No rendered prose, expected output, or
ja-source/is altered beyond replacing the unreproducible bitmap-hash count with the reproducible 4.x value.Verification — every touched example executed end-to-end on fresh single-BE clusters, reproducing the doc's printed output cell-for-cell:
🤖 Generated with Claude Code