[fix](sql-functions) provide setup data for FIELD examples (3.x / 2.1 + dev zh)#3901
Open
boluor wants to merge 1 commit into
Open
[fix](sql-functions) provide setup data for FIELD examples (3.x / 2.1 + dev zh)#3901boluor wants to merge 1 commit into
boluor wants to merge 1 commit into
Conversation
… + dev zh) The FIELD example pages query `baseall` and `class_test`, which the older copies never define, so the examples error with "table does not exist". The version-4.x page already carries a `-- setup` block and a self-consistent set of examples; the other copies were missing it (and the zh copies had an inconsistent example set: the ascending / descending outputs omitted the NULL row that the NULLS FIRST example shows). Port the version-4.x Examples section (setup + consistent custom-sort examples) to: - version-3.x, version-2.1 (EN) - dev (current), version-3.x, version-2.1 (ZH) version-4.x (EN+ZH) and dev EN already have it and are unchanged. Verified end-to-end on fresh single-BE clusters — 3.1.4, 2.1.11, and the local master daily build — every touched example reproduces the doc's printed output cell-for-cell (each page P9 F0, EN and ZH; NULLS FIRST/LAST confirmed on 2.1). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
FIELDexample pages querybaseallandclass_test, which the older copies never define, so a reader who runs them hitstable does not exist. The version-4.x page already carries a-- setupblock and a self-consistent example set; the other copies lacked it.For the zh copies there was also a pre-existing inconsistency: the ascending/descending outputs omitted the
NULLrow that theNULLS FIRSTexample shows (no singleclass_testcould satisfy both). version-4.x already resolved this.Port the version-4.x Examples section (setup + consistent custom-sort examples) to:
version-4.x (EN+ZH) and dev EN already have it — unchanged.
Verification — every touched example executed end-to-end on fresh single-BE clusters, reproducing the doc's printed output cell-for-cell (
NULLS FIRST/LASTconfirmed working on 2.1):🤖 Generated with Claude Code