Skip to content

[Enhancement][Build] set default do not build benchmark-tool && use lld/gold first#10215

Merged
yiguolei merged 1 commit intoapache:masterfrom
BiteTheDDDDt:fix_0617
Jun 25, 2022
Merged

[Enhancement][Build] set default do not build benchmark-tool && use lld/gold first#10215
yiguolei merged 1 commit intoapache:masterfrom
BiteTheDDDDt:fix_0617

Conversation

@BiteTheDDDDt
Copy link
Contributor

Proposed changes

  1. add a config to enable build benchmark-tool
  2. If lld/gold detected, set lld/gold to linker.

Problem Summary:

Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

HappenLee
HappenLee previously approved these changes Jun 20, 2022
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 20, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jun 20, 2022
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yiguolei yiguolei merged commit 4750e94 into apache:master Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants