-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[typo](docs) Update compile Dockerfile in developer #10339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adjust the default JDK version of the Docker build image from JDK-11 to JDK-1.8.0
|
Why downgrade the version of JDK? |
In the past practice process, I found that whether it is a developer or a community user, the JDK version is still mostly 1.8.0. In our Docker compiled image, the default JDK-11 version is adopted. Not paying attention to the JDK version problem often leads to taking time to compile, but getting a binary file with an incorrect JDK version, so I want to change the default JDK version of Doris's Docker compiled image to JDK-1.8.0. At the same time, I also sent a discussion email to the dev mailing group, welcome to reply to the discussion, thk~ |
|
As we disscussed in email and wechat, doris will support jdk 8 as default jdk so I will merge it. |
yiguolei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
Gabriel39
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: manyi <fop@freeoneplus.com>
Co-authored-by: manyi <fop@freeoneplus.com>
Adjust the default JDK version of the Docker build image from JDK-11 to JDK-1.8.0
Proposed changes
Issue Number: close #xxx
Problem Summary:
Describe the overview of changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...