Skip to content

[style](*): fix declarationOrder error by rearrange code #10347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 4 commits into from
Jul 1, 2022
Merged

[style](*): fix declarationOrder error by rearrange code #10347

yiguolei merged 4 commits into from
Jul 1, 2022

Conversation

@juinshell
Copy link
Contributor

@juinshell juinshell commented Jun 22, 2022

Proposed changes

None

Problem Summary:

fix some declarationOrder by IDEA Code/Rearrange Code

Checklist(Required)

  1. Does it affect the original behavior: No
  2. Has unit tests been added: No
  3. Has document been added or modified: No
  4. Does it need to update dependencies: No
  5. Are there any changes that cannot be rolled back: No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
@jackwener

@github-actions github-actions bot added the area/planner Issues or PRs related to the query planner label Jun 22, 2022
@jackwener
Copy link
Member

jackwener commented Jun 22, 2022

Great job.
Please add [style](*): XXXXX in the header.

PLAT @hf200012

@juinshell juinshell changed the title Rearrange code, fix declarationOrder error [style](*): fix declarationOrder error by rearrange code Jun 22, 2022
jackwener
jackwener approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
cc @hf200012 @yiguolei

@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2022

PR approved by anyone and no changes requested.

hf200012
hf200012 approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@hf200012 hf200012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LSTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 30, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2022

PR approved by at least one committer and no changes requested.

@yiguolei yiguolei merged commit 558a21d into apache:master Jul 1, 2022
@jackwener jackwener added dev/backlog waiting to be merged in future dev branch and removed dev/backlog waiting to be merged in future dev branch labels Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hf200012 hf200012 hf200012 approved these changes

@jackwener jackwener jackwener approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@juinshell @jackwener @hf200012 @yiguolei