Skip to content

[fix][be] Delete uncivilized comments.#10401

Closed
liuzhuang2017 wants to merge 1 commit intoapache:masterfrom
liuzhuang2017:be_runtime
Closed

[fix][be] Delete uncivilized comments.#10401
liuzhuang2017 wants to merge 1 commit intoapache:masterfrom
liuzhuang2017:be_runtime

Conversation

@liuzhuang2017
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem Summary:

Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@liuzhuang2017
Copy link
Contributor Author

@morningman , Sorry to bother you, can you help me review this pr? Thank you.

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 26, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman
Copy link
Contributor

hi @liuzhuang2017 , you have to rebase the master to let the check pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/vectorization reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments