Skip to content

[Fix] avoid core dump cause by malformed bitmap type data#10458

Merged
yiguolei merged 1 commit intoapache:masterfrom
yangzhg:avoid_bitmap_core
Jun 30, 2022
Merged

[Fix] avoid core dump cause by malformed bitmap type data#10458
yiguolei merged 1 commit intoapache:masterfrom
yangzhg:avoid_bitmap_core

Conversation

@yangzhg
Copy link
Member

@yangzhg yangzhg commented Jun 27, 2022

Proposed changes

Issue Number: close #10455

Problem Summary:

Malformed bitmap type data leads to be compaction or the query falls into an infinite loop of coredump, so add a check when write and read bitmap data, to avoid core dump

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@yangzhg yangzhg force-pushed the avoid_bitmap_core branch 2 times, most recently from 054cb6b to 791df21 Compare June 27, 2022 11:38
morningman
morningman previously approved these changes Jun 27, 2022
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but ut failed

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 27, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yangzhg
Copy link
Member Author

yangzhg commented Jun 28, 2022

LGTM, but ut failed

OK, I will fix it

@yangzhg yangzhg force-pushed the avoid_bitmap_core branch from 791df21 to 30145ff Compare June 28, 2022 07:27
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jun 28, 2022
@yangzhg yangzhg force-pushed the avoid_bitmap_core branch from 30145ff to 5b6782f Compare June 28, 2022 12:20
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit d259770 into apache:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Malformed bitmap type data leads to be compaction or the query falls into an infinite loop of coredump

3 participants