[hotfix](dev-1.0.1) abort load task if pending data exceed limit in table sink #10534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
changed the title
morningman
reviewed
Jul 1, 2022
| while(get_pending_bytes() < MAX_PENDING_BYTES){ | ||
| std::this_thread::sleep_for(std::chrono::microseconds(500)); | ||
| } | ||
| if (get_pending_bytes() > MAX_PENDING_BYTES) { |
Contributor
There was a problem hiding this comment.
Not a good fix.
If the data size in a single batch is larger than 500MB, user can not load data anymore.
Contributor
|
what‘s the problem for this PR to solve？ |
morningman
removed
the
dev/1.0.1-deprecated
Contributor
|
Resolve by #10552 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
abort load task if pending data exceed limit (500M) in table sink
Issue Number: close #xxx
Problem Summary:
Describe the overview of changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...